Adjusted the changelog generator to match to planned changes related to merging issue trackers #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to merging issue trackers.
pomek
commented
Aug 23, 2019
packages/ckeditor5-dev-env/lib/release-tools/utils/transform-commit/transform-commit-utils.js
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Other: Adjusted the changelog generator to match to planned changes related to merging issue trackers. Closes ckeditor/ckeditor5#1988.
BREAKING CHANGE: Due to merging our issue trackers,
pkgJson.bugswill point to the same place for every package. We cannot rely on this value anymore. See ckeditor/ckeditor5#1988. Instead of we can take a value frompkgJson.repositoryand adjust it to match to our requirements.Additional information
This PR won't change anything in our project because we already have defined
pkgJson.repositoryfor each package but if somebody uses the tool and he hasn't defined the value, the tool will throw an ugly error and that's why I marked it as BC.