Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cast all numbers to strings when playing with the cli-table package #732

Merged
merged 1 commit into from
Nov 18, 2021
Merged

Cast all numbers to strings when playing with the cli-table package #732

merged 1 commit into from
Nov 18, 2021

Conversation

pomek
Copy link
Member

@pomek pomek commented Nov 18, 2021

Suggested merge commit message (convention)

Fix (env): All numbers returned by the Transifex service will be cast to strings due to an error in the cli-package. See: Automattic/cli-table#152. Closes ckeditor/ckeditor5#10861.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 87.228% when pulling 9a43552 on i/10861 into 30acb45 on master.

psmyrek
psmyrek approved these changes Nov 18, 2021
View reviewed changes
Copy link
Contributor

@psmyrek psmyrek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@pomek pomek merged commit 7661137 into master Nov 18, 2021
@pomek pomek deleted the i/10861 branch November 18, 2021 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psmyrek psmyrek psmyrek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@pomek @coveralls @psmyrek