Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created release script that updates all
ckeditor5
dependencies to the latest version. #737Created release script that updates all
ckeditor5
dependencies to the latest version. #737Changes from 13 commits
11fa1c9
68536f7
7c3f456
9344acc
7090e1c
8b85dfc
0c5b3ca
b0910e9
1d07d15
0f71e49
c3a5d12
49cb082
b273e6e
e30a9ad
395e133
2e83188
d0e4536
cd941be
86aefbf
24a24af
c67c7d0
176e40b
0aabbee
55eae45
441bc44
7efde0a
4ae946e
1898110
6aa65a5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this regexp is needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to split these lines and merge them back together in order to pretty print the diff. Indentations are also kept in these lines, so there are more than one space. I suppose i could split using last space of a string instead, but this seems safer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if, for whatever reason, the script changes something else in the
package.json
file, other than the CKEditor 5 dependency versions? Now, only changes to the dependency versions are displayed in red and green colors, but other changes that could occur in the file are not highlighted in the console.The
--dry-run
flag should display all the changes that the script has made, to be sure that running it without this flag will not surprise us.If the dependency version has changed, it can be highlighted as it is now (only the version, not the full line). But when something else has changed that is not expected, let the entire changed line be highlighted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, i've actually taken this into account, but then i forgot to color the rest of changes, so good thing You pointed that out 😅
Single removals and additions are simple enough, they are just colored lines. But how do we want to show replacements?
a) Replacement on the same line
b) Replacement on the same line, but trim the whitespaces off the addition
c) Replacement on the line below
I'd suppose option b) is preferable, so this is what I'll do for now.