Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumped postcss to v8 #764

Merged
merged 9 commits into from Mar 22, 2022
Merged

Bumped postcss to v8 #764

merged 9 commits into from Mar 22, 2022

Conversation

przemyslaw-zan
Copy link
Member

@przemyslaw-zan przemyslaw-zan commented Mar 22, 2022

Suggested merge commit message (convention)

Feature (utils): The styles.getPostCssConfig() function returns a configuration compatible with postcss@8. See ckeditor/ckeditor5#11460.

MAJOR BREAKING CHANGE (utils): Upgraded the postcss version to 8 and marked the package as peer dependency instead of dependency. Starting from this version, when using the @ckeditor/ckeditor5-dev-utils, you need to manually install the postcss dependency.

Tests (env): Fixed broken tests on Windows.

Tests (env): Fixed deprecation warnings.

@coveralls
Copy link

coveralls commented Mar 22, 2022

Coverage Status

Coverage decreased (-0.02%) to 88.614% when pulling 4d992a3 on ck/11460 into 1d17df5 on master.

Copy link
Member

@pomek pomek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@pomek pomek merged commit bda2a8e into master Mar 22, 2022
@pomek pomek deleted the ck/11460 branch March 22, 2022 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants