Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

t/41: Renamed the ClassicEditor file to "classiceditor.js" to match the naming convention. #59

Merged
merged 3 commits into from
Jun 19, 2017
Merged

t/41: Renamed the ClassicEditor file to "classiceditor.js" to match the naming convention. #59

merged 3 commits into from
Jun 19, 2017

Conversation

oleq
Copy link
Member

@oleq oleq commented Jun 14, 2017 •
edited by pomek
Loading

Suggested merge commit message (convention)

Other: Renamed the ClassicEditor file to "classiceditor.js" to match the naming convention. Closes ckeditor/ckeditor5#2218.

BREAKING CHANGE: The classic.js file containing ClassicEditor class has been renamed to classiceditor.js.

@oleq
Copy link
Member Author

oleq commented Jun 14, 2017

The issue requires merging t/ckeditor5-editor-classic/41 branches in following repositories:

@ckeditor/ckeditor5-adapter-ckfinder                                   
@ckeditor/ckeditor5-autoformat                                         
@ckeditor/ckeditor5-block-quote                                       
@ckeditor/ckeditor5-basic-styles                                      
@ckeditor/ckeditor5-clipboard                                         
@ckeditor/ckeditor5-build-classic                                     
@ckeditor/ckeditor5-engine                                           
@ckeditor/ckeditor5-heading                                          
@ckeditor/ckeditor5-enter                                            
@ckeditor/ckeditor5-image                                            
@ckeditor/ckeditor5-link                                             
@ckeditor/ckeditor5-list                                             
@ckeditor/ckeditor5-paragraph                                        
@ckeditor/ckeditor5-presets                                          
@ckeditor/ckeditor5-typing                                           
@ckeditor/ckeditor5-ui                                               
@ckeditor/ckeditor5-undo                                             
@ckeditor/ckeditor5-upload

@oleq
Copy link
Member Author

oleq commented Jun 14, 2017

Mgit configuration is set in https://github.com/ckeditor/ckeditor5/tree/t/ckeditor5-editor-classic/41.

@oleq oleq requested a review from szymonkups June 19, 2017 11:59
@oleq
Copy link
Member Author

oleq commented Jun 19, 2017

When merging t/ckeditor5-editor-classic/41 in other repos the following commit message should be used

Internal: Updated the path to the ClassicEditor class (see https://github.com/ckeditor/ckeditor5-editor-classic/issues/41).

@szymonkups szymonkups merged commit 78afb44 into master Jun 19, 2017
@szymonkups szymonkups deleted the t/41 branch June 19, 2017 13:44
ngoov pushed a commit to ngoov/ckeditor5-editor-classic that referenced this pull request May 8, 2019
@oleq
Merge pull request ckeditor#59 from ckeditor/t/ckeditor5/1420
d862a1b 
Internal: Updated the `raw-loader` dependency to 1.0.0 (see ckeditor/ckeditor5#1420).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@szymonkups szymonkups Awaiting requested review from szymonkups

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@oleq @szymonkups