Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Commit

Permalink
Tests: Minimal test case for #1560.
Browse files Browse the repository at this point in the history
  • Loading branch information
f1ames committed Oct 1, 2018
1 parent 0821d90 commit 0531d87
Showing 1 changed file with 32 additions and 0 deletions.
32 changes: 32 additions & 0 deletions tests/view/renderer.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ import DocumentSelection from '../../src/view/documentselection';
import DomConverter from '../../src/view/domconverter';
import Renderer from '../../src/view/renderer';
import DocumentFragment from '../../src/view/documentfragment';
import DowncastWriter from '../../src/view/downcastwriter';
import CKEditorError from '@ckeditor/ckeditor5-utils/src/ckeditorerror';
import { parse, setData as setViewData, getData as getViewData } from '../../src/dev-utils/view';
import { INLINE_FILLER, INLINE_FILLER_LENGTH, isBlockFiller, BR_FILLER } from '../../src/view/filler';
Expand Down Expand Up @@ -3038,6 +3039,37 @@ describe( 'Renderer', () => {
expect( domRoot.innerHTML ).to.equal( '<p><a href="#href">Foo<i>Bar</i></a></p>' );
} );
} );

// #1560
describe( 'direct attributes manipulation', () => {
it( 'should rerender element if its attribute was removed before rendering', () => {
const writer = new DowncastWriter();

// 1. Setup.
viewRoot._appendChild( parse( '<container:p>1</container:p>' ) );

const viewP = viewRoot.getChild( 0 );

writer.setAttribute( 'data-placeholder', 'Body', viewP );

renderer.markToSync( 'children', viewRoot );
renderer.render();

expect( domRoot.innerHTML ).to.equal( '<p data-placeholder="Body">1</p>' );

// 2. Transform.
writer.removeAttribute( 'data-placeholder', viewP );

viewRoot._removeChildren( 0, viewRoot.childCount );

viewRoot._appendChild( parse( '<container:p>1</container:p><container:p>2</container:p>' ) );

renderer.markToSync( 'children', viewRoot );
renderer.render();

expect( domRoot.innerHTML ).to.equal( '<p>1</p><p>2</p>' );
} );
} );
} );

describe( '#922', () => {
Expand Down

0 comments on commit 0531d87

Please sign in to comment.