Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Commit

Permalink
Fixed some manual tests.
Browse files Browse the repository at this point in the history
  • Loading branch information
Kamil Piechaczek committed Nov 19, 2018
1 parent 71c4c19 commit 4f562a7
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion tests/manual/highlight.js
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ class FancyWidget extends Plugin {
model: 'fancywidget',
view: ( modelItem, viewWriter ) => {
const widgetElement = viewWriter.createContainerElement( 'figure', { class: 'fancy-widget' } );
viewWriter.insert( viewWriter.createPositionAt( widgetElement ), viewWriter.createText( 'widget' ) );
viewWriter.insert( viewWriter.createPositionAt( widgetElement, 'in' ), viewWriter.createText( 'widget' ) );

return toWidget( widgetElement, viewWriter );
}
Expand Down
2 changes: 1 addition & 1 deletion tests/manual/selection.html
Original file line number Diff line number Diff line change
Expand Up @@ -45,4 +45,4 @@
<p>baz</p>
</div>
<h2>Model contents:</h2>
<div id="model"></div>
<pre id="model"></pre>
2 changes: 1 addition & 1 deletion tests/manual/tickets/ckeditor5-721/1.js
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ ClassicEditor
const b = writer.createAttributeElement( 'b' );
const div = writer.createContainerElement( 'div' );

writer.insert( ViewPosition._createAt( div ), b );
writer.insert( ViewPosition._createAt( div, 'in' ), b );

return toWidget( div, writer, { label: 'element label' } );
}
Expand Down
4 changes: 2 additions & 2 deletions tests/view/manual/focus.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@ view.change( writer => {
text1 = writer.createText( 'Foo bar baz' );
text2 = writer.createText( 'Foo bar baz' );

writer.insert( ViewPosition._createAt( editable1 ), text1 );
writer.insert( ViewPosition._createAt( editable2 ), text2 );
writer.insert( ViewPosition._createAt( editable1, 0 ), text1 );
writer.insert( ViewPosition._createAt( editable2, 0 ), text2 );
} );

document.getElementById( 'button1' ).addEventListener( 'click', () => {
Expand Down
6 changes: 3 additions & 3 deletions tests/view/manual/focusobserver.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,10 @@ viewDocument.on( 'selectionChange', ( evt, data ) => {
} );

view.change( writer => {
writer.insert( writer.createPositionAt( editable1 ), writer.createText( 'First editable.' ) );
writer.insert( writer.createPositionAt( editable2 ), writer.createText( 'Second editable.' ) );
writer.insert( writer.createPositionAt( editable1, 0 ), writer.createText( 'First editable.' ) );
writer.insert( writer.createPositionAt( editable2, 0 ), writer.createText( 'Second editable.' ) );

writer.setSelection( editable1 );
writer.setSelection( editable1, 'end' );
} );

editable1.on( 'change:isFocused', () => {
Expand Down
2 changes: 1 addition & 1 deletion tests/view/manual/keyobserver.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ view.attachDomRoot( document.getElementById( 'editable' ), 'editable' );

view.change( writer => {
const text = writer.createText( 'foobar' );
writer.insert( writer.createPositionAt( viewRoot ), text );
writer.insert( writer.createPositionAt( viewRoot, 'in' ), text );
writer.setSelection( text, 3 );
} );

Expand Down

0 comments on commit 4f562a7

Please sign in to comment.