Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Commit

Permalink
Tests: Ignore rendering performance tests on Edge and increase timeou…
Browse files Browse the repository at this point in the history
…t to make tests more stable.
  • Loading branch information
f1ames committed Feb 14, 2019
1 parent 2b95dc3 commit 7815ab0
Showing 1 changed file with 19 additions and 12 deletions.
31 changes: 19 additions & 12 deletions tests/view/renderer.js
Original file line number Diff line number Diff line change
Expand Up @@ -3205,34 +3205,41 @@ describe( 'Renderer', () => {
// However, for larger data sets the difference between using `diff()` and `fastDiff()` (see above issue for context)
// is more than 10x in execution time so it is clearly visible in these tests when something goes wrong.
describe( 'rendering performance', () => {
it( 'should not take more than 250ms to render around 300 element nodes (same html)', () => {
before( function() {
// Ignore on Edge browser where performance is quite poor.
if ( env.isEdge ) {
this.skip();
}
} );

it( 'should not take more than 350ms to render around 300 element nodes (same html)', () => {
const renderingTime = measureRenderingTime( viewRoot, generateViewData1( 65 ), generateViewData1( 55 ) );
expect( renderingTime ).to.be.within( 0, 250 );
expect( renderingTime ).to.be.within( 0, 350 );
} );

it( 'should not take more than 250ms to render around 300 element nodes (different html)', () => {
it( 'should not take more than 350ms to render around 300 element nodes (different html)', () => {
const renderingTime = measureRenderingTime( viewRoot, generateViewData1( 55 ), generateViewData2( 65 ) );
expect( renderingTime ).to.be.within( 0, 250 );
expect( renderingTime ).to.be.within( 0, 350 );
} );

it( 'should not take more than 250ms to render around 500 element nodes (same html)', () => {
it( 'should not take more than 350ms to render around 500 element nodes (same html)', () => {
const renderingTime = measureRenderingTime( viewRoot, generateViewData1( 105 ), generateViewData1( 95 ) );
expect( renderingTime ).to.be.within( 0, 250 );
expect( renderingTime ).to.be.within( 0, 350 );
} );

it( 'should not take more than 250ms to render around 500 element nodes (different html)', () => {
it( 'should not take more than 350ms to render around 500 element nodes (different html)', () => {
const renderingTime = measureRenderingTime( viewRoot, generateViewData1( 95 ), generateViewData2( 105 ) );
expect( renderingTime ).to.be.within( 0, 250 );
expect( renderingTime ).to.be.within( 0, 350 );
} );

it( 'should not take more than 250ms to render around 1000 element nodes (same html)', () => {
it( 'should not take more than 350ms to render around 1000 element nodes (same html)', () => {
const renderingTime = measureRenderingTime( viewRoot, generateViewData1( 195 ), generateViewData1( 205 ) );
expect( renderingTime ).to.be.within( 0, 250 );
expect( renderingTime ).to.be.within( 0, 350 );
} );

it( 'should not take more than 250ms to render around 1000 element nodes (different html)', () => {
it( 'should not take more than 350ms to render around 1000 element nodes (different html)', () => {
const renderingTime = measureRenderingTime( viewRoot, generateViewData1( 205 ), generateViewData2( 195 ) );
expect( renderingTime ).to.be.within( 0, 250 );
expect( renderingTime ).to.be.within( 0, 350 );
} );

function measureRenderingTime( viewRoot, initialData, newData ) {
Expand Down

0 comments on commit 7815ab0

Please sign in to comment.