Fixed view tests.

src/view/emptyelement.js

@@ -68,7 +68,7 @@ export default class EmptyElement extends Element {
 			 *
 			 * @error view-emptyelement-cannot-add
 			 */
-			throw new CKEditorError( 'view-emptyelement-cannot-add: Cannot add child nodes to EmptyElement instance.' );
+			throw new CKEditorError( 'view-emptyelement-cannot-add: Cannot add child nodes to EmptyElement instance.', null );
 		}
 	}
 }

src/view/treewalker.js

@@ -42,12 +42,16 @@ export default class TreeWalker {
 			 *
 			 * @error view-tree-walker-no-start-position
 			 */
-			throw new CKEditorError( 'view-tree-walker-no-start-position: Neither boundaries nor starting position have been defined.' );
+			throw new CKEditorError(
+				'view-tree-walker-no-start-position: Neither boundaries nor starting position have been defined.',
+				null
+			);
 		}
 
 		if ( options.direction && options.direction != 'forward' && options.direction != 'backward' ) {
 			throw new CKEditorError(
 				'view-tree-walker-unknown-direction: Only `backward` and `forward` direction allowed.',
+				null,
 				{ direction: options.direction }
 			);
 		}

tests/view/attributeelement.js

@@ -131,7 +131,7 @@ describe( 'AttributeElement', () => {
 
 			expectToThrowCKEditorError( () => {
 				attribute.getElementsWithSameId();
-			}, /attribute-element-get-elements-with-same-id-no-id/, null );
+			}, /attribute-element-get-elements-with-same-id-no-id/ );
 		} );
 	} );
 

tests/view/documentselection.js

@@ -116,7 +116,7 @@ describe( 'DocumentSelection', () => {
 			expectToThrowCKEditorError( () => {
 				// eslint-disable-next-line no-new
 				new DocumentSelection( [ { invalid: 'range' } ] );
-			}, /view-selection-add-range-not-range/, view );
+			}, /view-selection-add-range-not-range/ );
 		} );
 
 		it( 'should throw an error when ranges intersects', () => {
@@ -126,14 +126,14 @@ describe( 'DocumentSelection', () => {
 			expectToThrowCKEditorError( () => {
 				// eslint-disable-next-line no-new
 				new DocumentSelection( [ range1, range2 ] );
-			}, 'view-selection-range-intersects', view );
+			}, 'view-selection-range-intersects' );
 		} );
 
 		it( 'should throw an error when trying to set to not selectable', () => {
 			expectToThrowCKEditorError( () => {
 				// eslint-disable-next-line no-new
 				new DocumentSelection( {} );
-			} ).to.throw( /view-selection-setTo-not-selectable/ );
+			}, /view-selection-setTo-not-selectable/ );
 		} );
 	} );
 
@@ -205,7 +205,7 @@ describe( 'DocumentSelection', () => {
 
 			expectToThrowCKEditorError( () => {
 				documentSelection._setFocus( endPos );
-			}, /view-selection-setFocus-no-ranges/, view );
+			}, /view-selection-setFocus-no-ranges/, documentSelection );
 		} );
 
 		it( 'modifies existing collapsed selection', () => {
@@ -810,15 +810,15 @@ describe( 'DocumentSelection', () => {
 
 				expectToThrowCKEditorError( () => {
 					otherSelection._setTo( {} );
-				} ).to.throw( /view-selection-setTo-not-selectable/ );
+				}, /view-selection-setTo-not-selectable/ );
 			} );
 
 			it( 'should throw an error when trying to set to not selectable #2', () => {
 				const otherSelection = new DocumentSelection();
 
 				expectToThrowCKEditorError( () => {
 					otherSelection._setTo();
-				} ).to.throw( /view-selection-setTo-not-selectable/ );
+				}, /view-selection-setTo-not-selectable/ );
 			} );
 		} );
 
@@ -862,7 +862,7 @@ describe( 'DocumentSelection', () => {
 
 				expectToThrowCKEditorError( () => {
 					documentSelection._setTo( foo );
-				}, /view-selection-setTo-required-second-parameter/, view );
+				}, /view-selection-setTo-required-second-parameter/, documentSelection );
 			} );
 
 			it( 'should collapse selection at node and flag', () => {
@@ -1009,7 +1009,7 @@ describe( 'DocumentSelection', () => {
 			it( 'should throw an error when range is invalid', () => {
 				expectToThrowCKEditorError( () => {
 					documentSelection._setTo( [ { invalid: 'range' } ] );
-				}, /view-selection-add-range-not-range/, view );
+				}, /view-selection-add-range-not-range/, documentSelection );
 			} );
 
 			it( 'should throw when range is intersecting with already added range', () => {
@@ -1018,7 +1018,7 @@ describe( 'DocumentSelection', () => {
 
 				expectToThrowCKEditorError( () => {
 					documentSelection._setTo( [ range1, range2 ] );
-				}, 'view-selection-range-intersects', view );
+				}, 'view-selection-range-intersects', documentSelection );
 			} );
 		} );
 

tests/view/downcastwriter/breakattributes.js

@@ -156,15 +156,15 @@ describe( 'DowncastWriter', () => {
 
 				expectToThrowCKEditorError( () => {
 					writer.breakAttributes( Range._createFromParentsAndOffsets( p1, 0, p2, 0 ) );
-				}, 'view-writer-invalid-range-container', view );
+				}, 'view-writer-invalid-range-container', writer );
 			} );
 
 			it( 'should throw when range has no parent container', () => {
 				const el = new AttributeElement( 'b' );
 
 				expectToThrowCKEditorError( () => {
 					writer.breakAttributes( Range._createFromParentsAndOffsets( el, 0, el, 0 ) );
-				}, 'view-writer-invalid-range-container', view );
+				}, 'view-writer-invalid-range-container', writer );
 			} );
 
 			it( 'should not break text nodes if they are not in attribute elements', () => {
@@ -246,7 +246,7 @@ describe( 'DowncastWriter', () => {
 
 				expectToThrowCKEditorError( () => {
 					writer.breakAttributes( position );
-				}, 'view-writer-cannot-break-empty-element', view );
+				}, 'view-writer-cannot-break-empty-element', writer );
 			} );
 
 			it( 'should throw if breaking inside EmptyElement #2', () => {
@@ -257,7 +257,7 @@ describe( 'DowncastWriter', () => {
 
 				expectToThrowCKEditorError( () => {
 					writer.breakAttributes( range );
-				}, 'view-writer-cannot-break-empty-element', view );
+				}, 'view-writer-cannot-break-empty-element', writer );
 			} );
 
 			it( 'should throw if breaking inside UIElement #1', () => {
@@ -267,7 +267,7 @@ describe( 'DowncastWriter', () => {
 
 				expectToThrowCKEditorError( () => {
 					writer.breakAttributes( position );
-				}, 'view-writer-cannot-break-ui-element', view );
+				}, 'view-writer-cannot-break-ui-element', writer );
 			} );
 
 			it( 'should throw if breaking inside UIElement #2', () => {
@@ -278,7 +278,7 @@ describe( 'DowncastWriter', () => {
 
 				expectToThrowCKEditorError( () => {
 					writer.breakAttributes( range );
-				}, 'view-writer-cannot-break-ui-element', view );
+				}, 'view-writer-cannot-break-ui-element', writer );
 			} );
 		} );
 	} );

tests/view/downcastwriter/breakcontainer.js

@@ -69,7 +69,7 @@ describe( 'DowncastWriter', () => {
 
 			expectToThrowCKEditorError( () => {
 				writer.breakContainer( selection.getFirstPosition() );
-			}, /view-writer-break-non-container-element/, view );
+			}, /view-writer-break-non-container-element/, writer );
 		} );
 
 		it( 'should throw if position parent is root', () => {
@@ -78,7 +78,7 @@ describe( 'DowncastWriter', () => {
 
 			expectToThrowCKEditorError( () => {
 				writer.breakContainer( position );
-			}, /view-writer-break-root/, view );
+			}, /view-writer-break-root/, writer );
 		} );
 	} );
 } );

tests/view/downcastwriter/clear.js

@@ -41,15 +41,15 @@ describe( 'DowncastWriter', () => {
 
 			expectToThrowCKEditorError( () => {
 				writer.clear( Range._createFromParentsAndOffsets( p1, 0, p2, 0 ) );
-			}, 'view-writer-invalid-range-container', view );
+			}, 'view-writer-invalid-range-container', writer );
 		} );
 
 		it( 'should throw when range has no parent container', () => {
 			const el = new AttributeElement( 'b' );
 
 			expectToThrowCKEditorError( () => {
 				writer.clear( Range._createFromParentsAndOffsets( el, 0, el, 0 ) );
-			}, 'view-writer-invalid-range-container', view );
+			}, 'view-writer-invalid-range-container', writer );
 		} );
 
 		it( 'should remove matched element from range', () => {

tests/view/downcastwriter/insert.js

@@ -156,9 +156,10 @@ describe( 'DowncastWriter', () => {
 			const element = new Element( 'b' );
 			const container = new ContainerElement( 'p' );
 			const position = new Position( container, 0 );
+
 			expectToThrowCKEditorError( () => {
 				writer.insert( position, element );
-			}, 'view-writer-insert-invalid-node', view );
+			}, 'view-writer-insert-invalid-node', writer );
 		} );
 
 		it( 'should throw when Element is inserted as child node', () => {
@@ -169,7 +170,7 @@ describe( 'DowncastWriter', () => {
 
 			expectToThrowCKEditorError( () => {
 				writer.insert( position, root );
-			}, 'view-writer-insert-invalid-node', view );
+			}, 'view-writer-insert-invalid-node', writer );
 		} );
 
 		it( 'should throw when position is not placed inside container', () => {
@@ -179,7 +180,7 @@ describe( 'DowncastWriter', () => {
 
 			expectToThrowCKEditorError( () => {
 				writer.insert( position, attributeElement );
-			}, 'view-writer-invalid-position-container', view );
+			}, 'view-writer-invalid-position-container', writer );
 		} );
 
 		it( 'should allow to insert EmptyElement into container', () => {
@@ -198,7 +199,7 @@ describe( 'DowncastWriter', () => {
 
 			expectToThrowCKEditorError( () => {
 				writer.insert( position, attributeElement );
-			}, 'view-writer-cannot-break-empty-element', view );
+			}, 'view-writer-cannot-break-empty-element', writer );
 		} );
 
 		it( 'should throw if trying to insert inside UIElement', () => {
@@ -209,7 +210,7 @@ describe( 'DowncastWriter', () => {
 
 			expectToThrowCKEditorError( () => {
 				writer.insert( position, attributeElement );
-			}, 'view-writer-cannot-break-ui-element', view );
+			}, 'view-writer-cannot-break-ui-element', writer );
 		} );
 	} );
 } );

tests/view/renderer.js

@@ -27,6 +27,7 @@ import createViewRoot from './_utils/createroot';
 import createElement from '@ckeditor/ckeditor5-utils/src/dom/createelement';
 import normalizeHtml from '@ckeditor/ckeditor5-utils/tests/_utils/normalizehtml';
 import env from '@ckeditor/ckeditor5-utils/src/env';
+import { expectToThrowCKEditorError } from '@ckeditor/ckeditor5-utils/tests/_utils/utils';
 
 describe( 'Renderer', () => {
 	let selection, domConverter, renderer;

tests/view/selection.js

@@ -117,7 +117,7 @@ describe( 'Selection', () => {
 			expectToThrowCKEditorError( () => {
 				// eslint-disable-next-line no-new
 				new Selection( [ { invalid: 'range' } ] );
-			}, /view-selection-add-range-not-range/, null );
+			}, /view-selection-add-range-not-range/ );
 		} );
 
 		it( 'should throw an error when ranges intersects', () => {
@@ -127,14 +127,14 @@ describe( 'Selection', () => {
 			expectToThrowCKEditorError( () => {
 				// eslint-disable-next-line no-new
 				new Selection( [ range1, range2 ] );
-			}, 'view-selection-range-intersects', selection );
+			}, 'view-selection-range-intersects' );
 		} );
 
 		it( 'should throw an error when trying to set to not selectable', () => {
 			expectToThrowCKEditorError( () => {
 				// eslint-disable-next-line no-new
 				new Selection( {} );
-			} ).to.throw( /view-selection-setTo-not-selectable/ );
+			}, /view-selection-setTo-not-selectable/ );
 		} );
 	} );
 
@@ -206,7 +206,7 @@ describe( 'Selection', () => {
 
 			expectToThrowCKEditorError( () => {
 				selection.setFocus( endPos );
-			}, /view-selection-setFocus-no-ranges/, selection );
+			}, /view-selection-setFocus-no-ranges/ );
 		} );
 
 		it( 'modifies existing collapsed selection', () => {
@@ -682,15 +682,15 @@ describe( 'Selection', () => {
 
 				expectToThrowCKEditorError( () => {
 					otherSelection.setTo( {} );
-				} ).to.throw( /view-selection-setTo-not-selectable/ );
+				}, /view-selection-setTo-not-selectable/ );
 			} );
 
 			it( 'should throw an error when trying to set to not selectable #2', () => {
 				const otherSelection = new Selection();
 
 				expectToThrowCKEditorError( () => {
 					otherSelection.setTo();
-				} ).to.throw( /view-selection-setTo-not-selectable/ );
+				}, /view-selection-setTo-not-selectable/ );
 			} );
 		} );
 
@@ -734,7 +734,7 @@ describe( 'Selection', () => {
 
 				expectToThrowCKEditorError( () => {
 					selection.setTo( foo );
-				}, /view-selection-setTo-required-second-parameter/, selection );
+				}, /view-selection-setTo-required-second-parameter/ );
 			} );
 
 			it( 'should collapse selection at node and flag', () => {
@@ -881,7 +881,7 @@ describe( 'Selection', () => {
 			it( 'should throw an error when range is invalid', () => {
 				expectToThrowCKEditorError( () => {
 					selection.setTo( [ { invalid: 'range' } ] );
-				}, /view-selection-add-range-not-range/, selection );
+				}, /view-selection-add-range-not-range/ );
 			} );
 
 			it( 'should throw when range is intersecting with already added range', () => {
@@ -890,7 +890,7 @@ describe( 'Selection', () => {
 
 				expectToThrowCKEditorError( () => {
 					selection.setTo( [ range1, range2 ] );
-				}, 'view-selection-range-intersects', selection );
+				}, 'view-selection-range-intersects' );
 			} );
 		} );
 

tests/view/textproxy.js

@@ -9,7 +9,6 @@ import ContainerElement from '../../src/view/containerelement';
 import DocumentFragment from '../../src/view/documentfragment';
 import RootEditableElement from '../../src/view/rooteditableelement';
 
-
 import createDocumentMock from '../../tests/view/_utils/createdocumentmock';
 import { expectToThrowCKEditorError } from '@ckeditor/ckeditor5-utils/tests/_utils/utils';
 
@@ -44,21 +43,21 @@ describe( 'TextProxy', () => {
 		it( 'should throw if wrong offsetInText is passed', () => {
 			expectToThrowCKEditorError( () => {
 				new TextProxy( text, -1, 2 ); // eslint-disable-line no-new
-			}, /view-textproxy-wrong-offsetintext/, null );
+			}, /view-textproxy-wrong-offsetintext/ );
 
 			expectToThrowCKEditorError( () => {
 				new TextProxy( text, 9, 1 ); // eslint-disable-line no-new
-			}, /view-textproxy-wrong-offsetintext/, null );
+			}, /view-textproxy-wrong-offsetintext/ );
 		} );
 
 		it( 'should throw if wrong length is passed', () => {
 			expectToThrowCKEditorError( () => {
 				new TextProxy( text, 2, -1 ); // eslint-disable-line no-new
-			}, /view-textproxy-wrong-length/, null );
+			}, /view-textproxy-wrong-length/ );
 
 			expectToThrowCKEditorError( () => {
 				new TextProxy( text, 2, 9 ); // eslint-disable-line no-new
-			}, /view-textproxy-wrong-length/, null );
+			}, /view-textproxy-wrong-length/ );
 		} );
 	} );