Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LivePosition throws error when RenameOperation is used #3840

Closed
scofalik opened this issue Oct 6, 2016 · 0 comments · Fixed by ckeditor/ckeditor5-engine#625
Closed

LivePosition throws error when RenameOperation is used #3840

scofalik opened this issue Oct 6, 2016 · 0 comments · Fixed by ckeditor/ckeditor5-engine#625
Labels
package:engine type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 4

Comments

@scofalik
Copy link
Contributor

scofalik commented Oct 6, 2016

When RenameOperation is a cause of change event on document, it makes LivePosition throw an error. This is because RenameOperation does not return range property needed by LivePosition. This issue was already addressed in LiveRange but it was ommited in LivePosition. Same fix will apply.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-engine Oct 9, 2019
@mlewand mlewand added this to the iteration 4 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:engine labels Oct 9, 2019
@scofalik scofalik mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package:engine type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 4
Development

Successfully merging a pull request may close this issue.

Fixed: LiveRange throwing after executing RenameOperation. ckeditor/ckeditor5-engine
2 participants
@scofalik @mlewand