Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for MS Edge #4049

Closed
Reinmar opened this issue Apr 18, 2017 · 3 comments · Fixed by ckeditor/ckeditor5-engine#926
Closed

Support for MS Edge #4049

Reinmar opened this issue Apr 18, 2017 · 3 comments · Fixed by ckeditor/ckeditor5-engine#926
Assignees
Labels
package:engine type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Milestone

Comments

@Reinmar
Copy link
Member

Reinmar commented Apr 18, 2017

See #423.

@Reinmar Reinmar self-assigned this Apr 18, 2017
@Reinmar
Copy link
Member Author

Reinmar commented Apr 18, 2017

I'll focus here on the most visible issues and tests which are easy to fix.

2 most important issues are usage of new Range() and non-yet-iterable DOM natives.

@Reinmar
Copy link
Member Author

Reinmar commented Apr 18, 2017

This is the status after my first batch of fixes:

Edge 14.14393.0 (Windows 10 0.0.0): Executed 3282 of 3282 (11 FAILED) (19.242 secs / 12.634 secs)

This is pretty good. The most worrying tests are those from the model because this is pure JS stuff ;|. I'll debug these. The rest are selection rendering and observer things which also fail in Firefox and could be extracted to a separate ticket.

@Reinmar
Copy link
Member Author

Reinmar commented Apr 20, 2017

Only 3 red tests remained now.

  1. In the renderer – should not be critical. May be just a test error.
  2. In the editing controller – unfortunately, when running these tests through a normal procedure selectionChange isn't fired. When running in debug mode, it is.
  3. In selection observer – the inf loop catcher doesn't work – may be that in this case Edge also doesn't fire selectionChange properly.

All these tests can be ignored for now. I'll make a PR with the current status of things because it will close ckeditor/ckeditor5-engine#925 immediately. I'll then do more manual tests and focus on issues which will pop out for them.

@mlewand mlewand transferred this issue from ckeditor/ckeditor5-engine Oct 9, 2019
@mlewand mlewand added this to the iteration 10 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:feature This issue reports a feature request (an idea for a new functionality or a missing option). package:engine labels Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:engine type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants