-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MS Edge support #423
Comments
Ok, I went through all the engine manual tests. I encountered only two issues – the selection locking and incorrect mutations. And of course I learnt even more how bad Edge dev tools are: https://twitter.com/reinmarpl/status/855339000613150725 |
Okey dokey. I've reviewed most of the things and, fortunately, I was able to either fix issues or they turned to be rather harmless. Automated testsNot all tests pass but more than 99%, so this is really good. Most of the broken tests are related to https://github.com/ckeditor/ckeditor5-ui/issues/214 so we can wait for Edge 15. Most importantly, these are the results for the engine:
One of these tests are unstable and the other two are related to some problems with Manual testsHere things also look quite well... if not the F12 tools. Edge's dev tools make it so terribly unstable that it renders them useless. However, with the dev tools closed the editor works really stable except two issues:
What's next?We're gonna support Edge just like other browsers – Chrome, Opera, Safari and Firefox. We don't need any particular actions to be taken. |
Let's follow here all the issues with Edge.
NOTE: Having the dev tools open makes Edge extremely unstable. This is ridiculous... but you need to test it with the console closed.
STATUS UPDATE: #423 (comment).
Engine
Ticket: https://github.com/ckeditor/ckeditor5-engine/issues/923.
new Range()
doesn't work (throws twice indomconverter.js
).NativeNodeList
isn't iterable (throws indomconverter.js
).Some broken model tests (which need to be debugged).FocusObserver
.And this happened (most likely that's a problem with re-rendering again):
Utils
Ticket: https://github.com/ckeditor/ckeditor5-utils/issues/150
nth()
test failsisRange()
test failsnew Range()
support.Typing
Each typed letter creates a new undo snapshot.new Range()
usage in the engine.UI
Balloon positioning: https://github.com/ckeditor/ckeditor5-ui/issues/212.
Dozen of failing
Template
tests (WAT?!)Clipboard
Core
Clean!
Features
Possible other issues
The text was updated successfully, but these errors were encountered: