Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Edge] Selection made by mouse gets stuck (freezes) in some cases #4053

Closed
Reinmar opened this issue Apr 21, 2017 · 10 comments
Closed

[Edge] Selection made by mouse gets stuck (freezes) in some cases #4053

Reinmar opened this issue Apr 21, 2017 · 10 comments
Labels
browser:edge package:engine resolution:wontfix This issue will not be fixed because the team decided that for given reasons it does not make sense. type:bug This issue reports a buggy (incorrect) behavior.

Comments

@Reinmar
Copy link
Member

Reinmar commented Apr 21, 2017

First spotted in #423.

Selection issues on Edge

So I thought that this is a problem with CKEditor 5 itself. I also noticed some issues with selection being lost or frozen on focus/blur, but then I tested that all events are fired fine and I also noticed that the same issue is reproducible in CKEditor 4:

apr-21-2017 14-36-50

This means that it's not CKEditor's problem as CKEditor 4 does nothing to the selection.

CKEditor 5 sometimes fixes selections if they got fixed when passed through view->model->view pipeline but, fortunately, this doesn't seem to cause any issues. Even when I'm making selection by dragging and the engine decides that it needs to re-render the selection, it doesn't break anything.

@Reinmar
Copy link
Member Author

Reinmar commented Apr 21, 2017

I reported it to MS: https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/11746000/, but there's a high chance that we'll have to find the trigger for this bug because it doesn't appear to be reproducible in a bare contenteditable.

@Reinmar
Copy link
Member Author

Reinmar commented Jun 22, 2017

It's still reproducible on http://ckeditor.com, but for some reasons I couldn't reproduce it in CKEditor 5.

However, I also noticed some issues when selection was reaching edges of inline styling and widgets. I can't reproduce them consistently, though.

@Reinmar
Copy link
Member Author

Reinmar commented Jun 27, 2017

Another case – #484.

Since @Mgsy confirmed that this particular case works fine in CKE4 we need to investigate how CKEditor 5 triggers it.

A couple of ideas:

  • Different styling?
  • Rendering after selection change which breaks selection-by-mouse-dragging. Perhaps, on Edge, when dragging from the right side of blocks, the selection is initially inserted outside of a block and our engine tries to fix that... or something :D.
  • Some volatile and unrelated trigger which breaks this in Edge.

@Reinmar Reinmar changed the title [Edge] Selection made by mouse gets stuck (freezes) when started in/near a list [Edge] Selection made by mouse gets stuck (freezes) in some cases Jun 27, 2017
@Mgsy
Copy link
Member

Mgsy commented Jun 27, 2017

I found another issues related to selection on Edge :

  1. Selection started at the marker can't be moved outside of it.

bug_cke5

  1. There's no possibility to select the marker character by character, because whole word receives selection immediately.

bug_cke5

@Reinmar
Copy link
Member Author

Reinmar commented Jun 27, 2017

Isn't the latter a standard Edge's behaviour when selecting text? It often extends the selection to whole words.

@Mgsy
Copy link
Member

Mgsy commented Jun 27, 2017

Isn't the latter a standard Edge's behaviour when selecting text? It often extends the selection to whole words.

It is, but this behaviour occurs if you extend the selection to more than one word. Basically, you are able to select first word character by character.

bug_cke5

Anyway, it's a tiny issue :)

@Mgsy
Copy link
Member

Mgsy commented Jul 5, 2017

Here is another case related to the selection on Edge.

bug_cke5

@ma2ciek
Copy link
Contributor

ma2ciek commented Apr 12, 2018

Some new(?) case:

  1. Bold some fragment
  2. Try to select text from the bold's boundary.

Result: cursor is stuck. I've checked and it works in CKE4.

@scofalik
Copy link
Contributor

CKE4 or CKE5?

@ma2ciek
Copy link
Contributor

ma2ciek commented Apr 12, 2018

It works in CKE4 and doesn't work in CKE5 beta-2 (https://ckeditor5.github.io/). I can check if it is not a regression.

@Reinmar Reinmar closed this as completed Jul 22, 2019
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-engine Oct 9, 2019
@mlewand mlewand added browser:edge resolution:wontfix This issue will not be fixed because the team decided that for given reasons it does not make sense. status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:engine labels Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser:edge package:engine resolution:wontfix This issue will not be fixed because the team decided that for given reasons it does not make sense. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

No branches or pull requests

5 participants