This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Prevent Writer from usage outside of the change block #1223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Few tests for errors miss. I'm on it. |
pjasiun
reviewed
Jan 4, 2018
src/model/writer.js
Outdated
| @@ -150,6 +150,10 @@ export default class Writer { | |||
| * second parameter is a {@link module:engine/model/item~Item model item}. | |||
| */ | |||
| insert( item, itemOrPosition, offset ) { | |||
| if ( this.model._currentWriter !== this ) { | |||
| throw new CKEditorError( 'writer-detached-writer-tries-to-modify-model: Detached writer tries to modify the model' ); | |||
| } | |||
There was a problem hiding this comment.
Wouldn't it be better to have it in a private method?
There was a problem hiding this comment.
Probably yes. I moved it to the separate private method.
|
Ready for the review. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Other: Prevented
Writerfrom usage outside of thechangeblock. Closes ckeditor/ckeditor5#4224.