This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 40
Changed public API to protected #1328
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
4708d59
Changed public API to protected.
5679955
Merge branch 'master' into t/738
ccaf364
Fixed invalid link in docs.
d9b62bb
Fixed docs and order of methods in class.
6354957
"model.Text#data" is protected now.
4ab06e2
"_clone()" method is now protected.
faba020
Added missing docs.
5272858
"view.Text#data" should be protected too.
28d2fe8
Merge branch 'master' into t/738
bf2f76a
"view.Text#data" is protected now.
65c3fbd
Changed order of the methods in code.
7852ef3
Added "view.Writer#setTextData()" for updating the content for specif…
b66c4c8
Added "model.Writer#setTextData()" for updating the content for speci…
a1f2732
Merge branch 'master' into t/738
206ed1e
Fixed failing tests.
5728e1f
Improved the docs.
1b83114
Merge branch 'master' into t/738
1139034
Fixed manual test for t/738.
szymonkups File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move
toJSON
andfromJSON
methods above protected ones. Please check other files you modified for correct order as described here. We sometimes forget about that but let's fix that starting with files modified in this PR.