This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Update model selection attributes after each change #1343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scofalik
reviewed
Mar 7, 2018
src/model/documentselection.js
Outdated
| const differ = model.document.differ; | ||
|
|
||
| for ( const entry of differ.getChanges() ) { | ||
| if ( entry.type != 'insert' || !entry.position.parent ) { |
There was a problem hiding this comment.
!entry.position.parent - is there any situation when this happens? 🤔
…adding them during attribute auto-update.
This was referenced Mar 8, 2018
scofalik
added a commit
to ckeditor/ckeditor5-autoformat
that referenced
this pull request
Mar 8, 2018
Internal: Align to changes made in DocumentSelection. See ckeditor/ckeditor5-engine#1343.
scofalik
added a commit
to ckeditor/ckeditor5-undo
that referenced
this pull request
Mar 8, 2018
Internal: Align to changes made in DocumentSelection. See ckeditor/ckeditor5-engine#1343.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix:
model.DocumentSelectionshould update it's attributes after each change, including external changes. Closes ckeditor/ckeditor5#4258.Close together with: ckeditor/ckeditor5-undo#83 and ckeditor/ckeditor5-autoformat#52.