This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Introduced .isBefore() and .isAfter() in model.Node and view.Node #1368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oskarwrobel
reviewed
Mar 19, 2018
src/view/node.js
Outdated
| /** | ||
| * Clones this node. | ||
| * | ||
| * @method #clone |
oskarwrobel
reviewed
Mar 19, 2018
| } | ||
|
|
||
| // In other cases, just check if the `node` is before, and return the opposite. | ||
| return !this.isBefore( node ); |
oskarwrobel
reviewed
Mar 19, 2018
src/view/position.js
Outdated
| } | ||
| // Get path from root to position's parent element. "Indexify" the paths (change elements to indices). | ||
| const thisPath = this.getAncestors().map( element => element.index ); | ||
| const otherPath = otherPosition.getAncestors().map( element => element.index ); |
There was a problem hiding this comment.
WDYT about using just introduced Node#getPath()?
const thisPath = this.parent.is( 'node' ) ? this.parent.getPath() : [];
const otherPath = otherPosition.parent.is( 'node' ) ? otherPosition.parent.getPath() : []and shifting null from array won't be necessary.
|
I left 2 small comments but works and looks fine in general 👍 |
|
Fixed according to comments. |
… similar to `model.Position#compareWith`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Feature: Introduced
#isBeforeand#isAfterinmodel.Nodeandview.Node. Additionally,model.Node#isandview.Node#isandview.Node#getPathwere added. Closes ckeditor/ckeditor5#4318.