This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 40
Tests: New cases which include ranges in blocks in OT tests #1494
Merged
Changes from 5 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
ae2c6cf
Added: Test cases with a range inside a block.
Mgsy 89a5546
Added: Test cases with a range inside a block.
Mgsy 2fa6fd0
Added: New scenarios and cleanup.
Mgsy c68cb11
Code style.
Mgsy e5b3ed4
Added: New scenarios.
Mgsy d35441d
Improved scenarios and code style.
Mgsy 7791610
Changed naming and code style.
Mgsy c09c26c
Merge branch 'master' into t/1470
Mgsy 0f9779e
Removed cases when text receives wrap.
Mgsy 48d4e83
Merge branch 'master' into t/1470
Mgsy 98246a1
Fixed: Syntax errors.
Mgsy 62cd195
Fixed: Initial data in AttributeOperation test.
Mgsy dfa206c
Added: Scenarios for remove attribute x wrap/unwrap/split.
Mgsy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why you removed those tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I moved all
remove attribute
tests to theattribute.js
file.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, didn't see that cause attribute.js was not expanded. What about the wrap test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops, I see that wrap, unwrap and split don't have this kind of tests. I'll add them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've meant that there is a removed test in
move.js
:'intersecting wrap'
. I've commented on that below.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.