This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Changed long name returned by Operation.className property to the short one #1514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjasiun
reviewed
Aug 27, 2018
| @@ -112,7 +112,7 @@ export default class Operation { | |||
| * @type {String} | |||
| */ | |||
| static get className() { | |||
| return 'engine.model.operation.Operation'; | |||
| return 'Operation'; | |||
| } | |||
There was a problem hiding this comment.
I think you should never ask for this property of the base class. I think we should remove this method or replace it with throw.
There was a problem hiding this comment.
Agree that this method should be never used (in source code) for the base class. But If you want to drop this method for Operation class let's do it in a separate ticket because it needs some fixes in toJSON() method and in tests.
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Feature: Changed long name returned by
Operation.classNameproperty to the short one. Closes ckeditor/ckeditor5#4403.Additional information
For example – encountered issues, assumptions you had to make, other affected tickets, etc.