This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Upcast element to attribute defaults to 'low' priority instead of 'normal' #1611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is a related PR in |
Mgsy
approved these changes
Dec 13, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Other: Upcast element to attribute defaults to
lowpriority instead ofnormal. Closes ckeditor/ckeditor5#1399.Additional information
See ckeditor/ckeditor5#1399 and ckeditor/ckeditor5#1399 (comment).
I'm not sure, should it be marked as breaking change?
As for testing I have run unit tests from all packages and did some manual testing. However, @Mgsy could also take a quick look. This PR changes the order of conversions (so elements first and then its attributes) so any operation which involves both converting element and its attributes its affected.
Btw. The failing CI tests are just selection tests failing on Edge (ckeditor/ckeditor5#4449).