Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Feature: Implemented Selection#is() and DocumentSelection#is() methods. #1670

Merged
merged 2 commits into from
Feb 8, 2019

Conversation

oleq
Copy link
Member

@oleq oleq commented Feb 8, 2019

Suggested merge commit message (convention)

Feature: Implemented Selection#is() and DocumentSelection#is() methods in both the model and the view. Closes ckeditor/ckeditor5#4477.


A piece of https://github.com/ckeditor/ckeditor5-engine/issues/1667. To get rid of instanceof checks we must implement is() in other classes too.

@pjasiun
Copy link

pjasiun commented Feb 8, 2019

I think you should add the same methods to engine#view.selection and engine#view.documentselection

@coveralls
Copy link

coveralls commented Feb 8, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling b81e921 on t/1663 into c9932b8 on master.

@oleq oleq requested a review from pjasiun February 8, 2019 11:40
@pjasiun
Copy link

pjasiun commented Feb 8, 2019

I think that to close #1663 this ticket should also replace usage of instanceof with new is method.

Nvmd. Lets close #1667 first to be safer.

@pjasiun pjasiun merged commit aac4948 into master Feb 8, 2019
@pjasiun pjasiun deleted the t/1663 branch February 8, 2019 13:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants