This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Feature: Implemented Selection#is() and DocumentSelection#is() methods. #1670
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Feature: Implemented
Selection#is()
andDocumentSelection#is()
methods in both the model and the view. Closes ckeditor/ckeditor5#4477.A piece of https://github.com/ckeditor/ckeditor5-engine/issues/1667. To get rid of
instanceof
checks we must implementis()
in other classes too.