Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Update model selection data before the post fixers are called. #1674

Merged
merged 3 commits into from
Feb 12, 2019
Merged

Conversation

oskarwrobel
Copy link
Contributor

@oskarwrobel oskarwrobel commented Feb 11, 2019

Suggested merge commit message (convention)

Fix: Update model selection data after each change that affects the selection. Closes https://github.com/ckeditor/ckeditor5-engine/issues/1673.


Additional information

For example – encountered issues, assumptions you had to make, other affected tickets, etc.

@coveralls
Copy link

coveralls commented Feb 11, 2019

Coverage Status

Coverage increased (+7.0e-06%) to 99.992% when pulling 082847c on t/1673 into 5862d70 on master.

@pjasiun
Copy link

pjasiun commented Feb 11, 2019

I think that we should keep selection attributes and markers up-to-date, so it should be updated after each operation applied.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants