This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Automatic marker re-rendering during conversion for markers which view element was unbound #1781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for markers which view element was unbound.
pjasiun
reviewed
Aug 13, 2019
|
I've updated docs for I mean, I have a scenario that crashed without this fix but maybe actually it is possible (and makes sense) to provide a smaller fix than this. |
…d with marker is broken.
pjasiun
reviewed
Aug 16, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Other: Introduced automatic marker re-rendering during conversion for markers which view element was unbound. Closes ckeditor/ckeditor5#4532.
BREAKING CHANGE: New parameter introduced in
DowncastDispatcher#convertChanges(). Now it isconvertChanges( differ, markers, writer ).BREAKING CHANGE: Although it was rather impossible to use
DowncastDispatcherwithout specifying any conversion API in the constructor, now it is a required parameter.