Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

I/6152: Added 'mouseup', 'mousemove' and 'mouseleave' events to MouseObserver. #1819

Closed
wants to merge 3 commits into from

Conversation

jodator
Copy link
Contributor

@jodator jodator commented Jan 28, 2020

Suggested merge commit message (convention)

Enhancement: Added 'mouseup', 'mousemove' and 'mouseleave' events to MouseObserver. Closes ckeditor/ckeditor5#6152.


Additional information

  • This PR adds events required by table selection feature. At this stage, it is not required by its own.
  • The events in table selection are used to:
    • 'mouseup' - stop selecting table cells
    • 'mousemove' -
    • 'mouseleave'

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 7f4d92a on i/6152 into 48bea53 on master.

@jodator
Copy link
Contributor Author

jodator commented Jan 28, 2020

Actually it makes no sense to make this now in the engine as we can introduce this in table selection.

@jodator jodator closed this Jan 28, 2020
@jodator jodator deleted the i/6152 branch January 28, 2020 14:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants