This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
i/6225: Fix for the ";" styles after removing margin entries. #1823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nal object. When removing normalized style values (like 'margin-right', 'margin-top', etc) one by one the base 'margin' entry was not cleared. This caused problems with checking for emptiness of StylesMap and was causing wrong toString() output with ';'.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix: Removing normalized properties from styles map should clean the internal object. Closes ckeditor/ckeditor5#6225.
Additional information
When removing normalized style values (like 'margin-right', 'margin-top', etc) one by one the base 'margin' entry was not cleared. This caused problems with checking for the emptiness of StylesMap and was causing wrong toString() output with ';'.