This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
I/6501: Handle intersecting ranges when fixing graveyard selection #1834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ulti-range selection in text node.
Reinmar
reviewed
Apr 10, 2020
tests/model/documentselection.js
Outdated
| @@ -1778,6 +1778,63 @@ describe( 'DocumentSelection', () => { | |||
| // Now it's clear that it's the default range. | |||
| expect( selection.getFirstPosition().path ).to.deep.equal( [ 0, 0 ] ); | |||
| } ); | |||
|
|
|||
| it( 'does not break if multi-range selection is inside text nodes', () => { | |||
There was a problem hiding this comment.
"Does not break" does not explain what should actually happen. I prefer explaining what's the expected result.
Suggested change
| it( 'does not break if multi-range selection is inside text nodes', () => { | |
| it( 'handles multi-range selection in a text node by merging it into one range', () => { |
There was a problem hiding this comment.
BTW, as mentioned in the test description – I'd actually expect the ranges to be merged if they are identical. Would that require a lot of work?
There was a problem hiding this comment.
I'd actually expect the ranges to be merged if they are identical.
I don't see a need to merging two identical ranges. With intersecting ones I would have to check.
Reinmar
reviewed
Apr 10, 2020
tests/model/documentselection.js
Outdated
| expect( selection.getLastPosition().path ).to.deep.equal( [ 1, 1 ] ); | ||
| } ); | ||
|
|
||
| it( 'does not break if multi-range selection is set on object nodes and resulting ranges will intersect', () => { |
There was a problem hiding this comment.
Again – explain what's expected.
Reinmar
reviewed
Apr 10, 2020
tests/model/documentselection.js
Outdated
| expect( selection.getLastPosition().path ).to.deep.equal( [ 1, 1 ] ); | ||
| } ); | ||
|
|
||
| it( 'does not break if multi-range selection is set on object nodes and resulting ranges will intersect', () => { |
There was a problem hiding this comment.
Again – explain what's expected.
Reinmar
suggested changes
Apr 10, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix: Intersecting ranges resulting when fixing graveyard selection no longer breaks the editor. Closes ckeditor/ckeditor5#6501. Closes ckeditor/ckeditor5#6382.
Additional information
PR to merge together: ckeditor/ckeditor5-table#293.
Well, it looks like intersecting ranges will be created on such modifications as in tables: multi-range selection set on table cells and their parent is removed. This would result in many ranges being fixed to the same range (thus intersecting with any other fixed range).
As with other ranges/positions fixes, I am not sure if I have a broad view of this problem. The proposed solution fixes this case and does not break other CKEditor 5 tests buuuut we do not have every case tested.