T/329 Split Selection to Selection and DocumentSelection #505
Conversation
|
The only important difference between |
|
Done |
| @@ -162,7 +162,6 @@ export default class Document { | |||
| this.version++; | |||
|
|
|||
| if ( operation.delta ) { | |||
| // Right now I can't imagine operations without deltas, but let's be safe. | |||
| this.history.addDelta( operation.delta ); | |||
Conflicts: src/model/document.js tests/model/selection.js
|
Done. |
| * | ||
| * @returns {engine.model.Selection} Selection instance which ranges and direction is equal to this selection. | ||
| */ | ||
| getSnapshot() { |
There was a problem hiding this comment.
We have Position.createFromPosition, Range.createFromRange so why not Selection.createFromSelection?
There was a problem hiding this comment.
In fact I do not like these method, I prefer .clone( isDynamic ) but it is more important to have a consistent API now, we can discuss it in the separate issue.
There was a problem hiding this comment.
In fact, why not Zoidberg?
There was a problem hiding this comment.
I created a follow-up: https://github.com/ckeditor/ckeditor5-engine/issues/507
…on. Docs: Selection#_ranges is now protected.
|
Done. |
This PR fixes ckeditor/ckeditor5#3644
Notable changes:
DocumentSelectionwhich has same features as "old"Selection.Selectionis now static, meaning that it does not createLiveRanges and does not update when document changes.Selectionhas no attributes API.Selectionhas no "default range".DocumentSelectionhasgetSnapshotmethod that returnsSelectioninstance with same ranges and direction as thatDocumentSelection.New
Selectionclass is meant to be used when you need to cached it or in methods that may/have to modify selection.