Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

T/629b Alternative fix infinite selection loop. #671

Merged
merged 24 commits into from
Nov 16, 2016
Merged

T/629b Alternative fix infinite selection loop. #671

merged 24 commits into from
Nov 16, 2016

Commits on Nov 2, 2016

  1. Fixed: infinite selection fixing loop.

    @scofalik
    scofalik committed Nov 2, 2016
    Configuration menu
    Copy the full SHA
    f4c0d25 View commit details
    Browse the repository at this point in the history

  2. Fixed: clear infinite loop counter after user interaction.

    @scofalik
    scofalik committed Nov 2, 2016
    Configuration menu
    Copy the full SHA
    b9d6bc2 View commit details
    Browse the repository at this point in the history

  3. Fixed: view.Selection#isEqual better algorithm.

    @scofalik
    scofalik committed Nov 2, 2016
    Configuration menu
    Copy the full SHA
    1b39bfb View commit details
    Browse the repository at this point in the history

  4. Fixed: view.Selection#isEqual for fake selections.

    @scofalik
    scofalik committed Nov 2, 2016
    Configuration menu
    Copy the full SHA
    d2d1e73 View commit details
    Browse the repository at this point in the history

  5. Tests: fixed failed tests and 100% CC.

    @scofalik
    scofalik committed Nov 2, 2016
    Configuration menu
    Copy the full SHA
    a656829 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2016

  1. Changed: SelectionObserver clearing infinite loop counter in time int… 

    …ervals.
    @scofalik
    scofalik committed Nov 9, 2016
    Configuration menu
    Copy the full SHA
    d80b367 View commit details
    Browse the repository at this point in the history

  2. Tests: SelectionObserver infinite loop removed unstable unit tests an… 

    …d added manual test.
    @scofalik
    scofalik committed Nov 9, 2016
    Configuration menu
    Copy the full SHA
    317d3dc View commit details
    Browse the repository at this point in the history

  3. Tests: updated manual test description.

    @scofalik
    scofalik committed Nov 9, 2016
    Configuration menu
    Copy the full SHA
    f220109 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into t/629b

    @Reinmar
    Reinmar committed Nov 9, 2016
    Configuration menu
    Copy the full SHA
    a83c2ab View commit details
    Browse the repository at this point in the history

  5. Manual ticket tests should also be inside manual/ directory.

    @Reinmar
    Reinmar committed Nov 9, 2016
    Configuration menu
    Copy the full SHA
    6b6da0c View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2016

  1. Tests: Improved cleanup.

    @Reinmar
    Reinmar committed Nov 10, 2016
    Configuration menu
    Copy the full SHA
    3768f04 View commit details
    Browse the repository at this point in the history

  2. Tests: Cleaning listeners should not be necessary since we're disabli… 

    …ng the observer (so view#selChange won't be fired).
    @Reinmar
    Reinmar committed Nov 10, 2016
    Configuration menu
    Copy the full SHA
    3dc704c View commit details
    Browse the repository at this point in the history

  3. Tests: Fixed a selection observer test which could never work, but wa… 

    …s hard to find because it depended on how you executed the tests.
    @Reinmar
    Reinmar committed Nov 10, 2016
    Configuration menu
    Copy the full SHA
    a8e53ca View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2016

  1. Added: Implemented destroy chain for EditingController->observers->do… 

    …m events.
    @scofalik
    scofalik committed Nov 15, 2016
    Configuration menu
    Copy the full SHA
    dcf65b8 View commit details
    Browse the repository at this point in the history

  2. Fixed: Selection#isEqual was throwing in the selection had no ranges.

    @scofalik
    scofalik committed Nov 15, 2016
    Configuration menu
    Copy the full SHA
    0de2bf7 View commit details
    Browse the repository at this point in the history

  3. Docs: added/fixed code comments.

    @scofalik
    scofalik committed Nov 15, 2016
    Configuration menu
    Copy the full SHA
    25b8ba2 View commit details
    Browse the repository at this point in the history

  4. Tests: Additional tests for model.Selection and view.SelectionObserver.

    @scofalik
    scofalik committed Nov 15, 2016
    Configuration menu
    Copy the full SHA
    a3690d5 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into t/629b

    @Reinmar
    Reinmar committed Nov 15, 2016
    Configuration menu
    Copy the full SHA
    b1e0e1f View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2016

  1. Changed: simplified implementation of model/view.Selection#isEqual.

    @scofalik
    scofalik committed Nov 16, 2016
    Configuration menu
    Copy the full SHA
    adcdbdc View commit details
    Browse the repository at this point in the history

  2. Tests: added additional test for EditingController#destroy.

    @scofalik
    scofalik committed Nov 16, 2016
    Configuration menu
    Copy the full SHA
    6a2418b View commit details
    Browse the repository at this point in the history

  3. Docs: added missing documentation.

    @scofalik
    scofalik committed Nov 16, 2016
    Configuration menu
    Copy the full SHA
    7ccaa13 View commit details
    Browse the repository at this point in the history

  4. Tests: expanded tests for model/view.Selection to cover more cases.

    @scofalik
    scofalik committed Nov 16, 2016
    Configuration menu
    Copy the full SHA
    bf9fc9f View commit details
    Browse the repository at this point in the history

  5. Tests: Should not log a warning which is expected to be logged.

    @Reinmar
    Reinmar committed Nov 16, 2016
    Configuration menu
    Copy the full SHA
    bf87840 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into t/629b

    @Reinmar
    Reinmar committed Nov 16, 2016
    Configuration menu
    Copy the full SHA
    6a9306e View commit details
    Browse the repository at this point in the history