This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Implemented DC.toModel #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Besides adding the new method I also added tests for the other ones, to confirm that they work with document fragments. We used doc frag convertion already in the clipboard, so the engine code was outdated. |
scofalik
reviewed
Dec 8, 2016
|
|
||
| const viewElement = data.toView( modelElement ).getChild( 0 ); | ||
| const viewElement = viewDocumentFragment.getChild( 0 ); |
There was a problem hiding this comment.
It would be more complete if you check both children.
There was a problem hiding this comment.
Agree. But this is not a test for conversion itself, but for methods utilising conversion.
There was a problem hiding this comment.
I mean – there are a lot more things which could be broken below, but it'd be unwise to try to test them so late. I'm checking the number of children and the first child to verify that enough elements were converted and that they make some sense.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ckeditor/ckeditor5#3887.