Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The special behaviour or Enter should be always enabled #2429

Closed
Reinmar opened this issue Oct 31, 2016 · 1 comment · Fixed by ckeditor/ckeditor5-heading#51
Closed

The special behaviour or Enter should be always enabled #2429

Reinmar opened this issue Oct 31, 2016 · 1 comment · Fixed by ckeditor/ckeditor5-heading#51
Assignees
Labels
package:heading type:bug This issue reports a buggy (incorrect) behavior.
Milestone

Comments

@Reinmar
Copy link
Member

Reinmar commented Oct 31, 2016

Right now we check whether the enter command exists. If, however, the heading feature was loaded first, this is not going to work.

I noticed this issue because the autoformatter incorrectly requires all features and it's loaded first (the list is sorted alphabetically :D) – https://github.com/ckeditor/ckeditor5-autoformat/issues/5.

In this case, either we should check the command later on, on runtime, or, like in https://github.com/ckeditor/ckeditor5-autoformat/issues/5, we need a post init event.

@Reinmar
Copy link
Member Author

Reinmar commented Nov 29, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:heading type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
2 participants