Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The HeadingCommand class should care only about modelElement #2449

Closed
Reinmar opened this issue Jun 8, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-heading#79
Closed

The HeadingCommand class should care only about modelElement #2449

Reinmar opened this issue Jun 8, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-heading#79
Assignees
@Reinmar
Labels
package:heading type:improvement This issue reports a possible enhancement of an existing feature.
Milestone
iteration 11

Comments

@Reinmar
Copy link
Member

Reinmar commented Jun 8, 2017

Right now the command exposes all the HeadingOption's properties – modelElement, viewElement, title. Only the first is used, the rest are there for no reason.
szymonkups referenced this issue in ckeditor/ckeditor5-heading Jun 8, 2017
@szymonkups
Merge pull request #79 from ckeditor/t/78
c80e691 
Other: Removed `HeadingCommand`'s properties which were exposed unnecessarily. Closes #78.

BREAKING CHANGE: The `HeadingCommand` constructor's second parameter was changed from the options object to the `modelElement` alone.

NOTE: The `HeadingOption` interface was moved to the `heading/heading` module.
@Reinmar Reinmar self-assigned this Jun 8, 2017
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-heading Oct 9, 2019
@mlewand mlewand added this to the iteration 11 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:improvement This issue reports a possible enhancement of an existing feature. package:heading labels Oct 9, 2019
@Reinmar Reinmar mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Reinmar Reinmar

Labels
package:heading type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
iteration 11
Development

Successfully merging a pull request may close this issue.

Removed unnecessary HeadingCommand properties ckeditor/ckeditor5-heading
2 participants
@Reinmar @mlewand