Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ctrl+A in a nested editable must select that nested editable's content #5066

Closed
Reinmar opened this issue Feb 21, 2017 · 4 comments
Closed

Ctrl+A in a nested editable must select that nested editable's content #5066

Reinmar opened this issue Feb 21, 2017 · 4 comments
Assignees
@oleq
Labels
package:image type:improvement This issue reports a possible enhancement of an existing feature.
Milestone
iteration 11

Comments

@Reinmar
Copy link
Member

Reinmar commented Feb 21, 2017

Right now, when you press Ctrl+A the selection is moved out of the nested editable. This needs to be handled by widgtes.
@oleq
Copy link
Member

oleq commented Mar 21, 2017

Side question: Why doesn't CTRL+A select the content of the editor in http://localhost:8125/ckeditor5-image/tests/manual/caption.html? Some missing plugin?

@Reinmar
Copy link
Member Author

Reinmar commented Mar 21, 2017

No. This happens because the editor's content ends with a cE=false element. Blink's and Webkit's selection implementations are limited and don't allow placing one of the boundaries in such a place. So CTRL+A does nothing in such a case.

The most reasonable solution I can think of is handling CTRL+A manually and patching renderer so it creates space at the beginning/end of the editable so the boundary can be rooted there.

@Reinmar
Copy link
Member Author

Reinmar commented Mar 21, 2017

But all this is a separate issue. It's not related to CTRL+A inside a nested editable.

@oleq
Copy link
Member

oleq commented Mar 21, 2017

Thanks, I was just curious.

@Reinmar Reinmar self-assigned this Jul 28, 2017
@Reinmar Reinmar removed their assignment Aug 17, 2017
@oleq oleq self-assigned this Aug 17, 2017
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-image Oct 9, 2019
@mlewand mlewand added this to the iteration 11 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:improvement This issue reports a possible enhancement of an existing feature. package:image labels Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

Labels
package:image type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
iteration 11
Development

No branches or pull requests
3 participants
@Reinmar @oleq @mlewand