Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Used UI#update event instead of View#render to attach the UI components. #215

Merged
merged 8 commits into from
Jun 29, 2018
Merged

Used UI#update event instead of View#render to attach the UI components. #215

merged 8 commits into from
Jun 29, 2018

Conversation

oskarwrobel
Copy link
Contributor

@oskarwrobel oskarwrobel commented Jun 26, 2018 •
edited by pomek
Loading

Suggested merge commit message (convention)

Internal: Used UI#update event instead of View#render to attach the UI components. Closes ckeditor/ckeditor5#5118.

Part of

@oskarwrobel oskarwrobel requested a review from oleq June 26, 2018 15:52
@oskarwrobel oskarwrobel mentioned this pull request Jun 26, 2018
Merged
@oskarwrobel oskarwrobel mentioned this pull request Jun 27, 2018
Closed
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.3%) to 98.659% when pulling c9eaa09 on t/142 into 1128cb8 on master.

@oskarwrobel
Copy link
Contributor Author

oskarwrobel commented Jun 28, 2018 •
edited
Loading

Interesting 🤔

image

@oleq oleq merged commit dee20c0 into master Jun 29, 2018
@oleq oleq deleted the t/142 branch June 29, 2018 08:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@oleq oleq Awaiting requested review from oleq

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@oskarwrobel @coveralls @oleq