Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

T/ckeditor5/1985: Change how the temporary upload image is handled. #316

Merged
merged 7 commits into from
Aug 23, 2019

Conversation

jodator
Copy link
Contributor

@jodator jodator commented Aug 21, 2019

Suggested merge commit message (convention)

Fix: Image upload should handle images that are deeply nested in other blocks. Closes ckeditor/ckeditor5#1985.


Additional information

@coveralls
Copy link

coveralls commented Aug 21, 2019

Coverage Status

Coverage decreased (-0.3%) to 99.405% when pulling a3768e2 on t/ckeditor5/1985 into c3c0e4a on master.

@Reinmar
Copy link
Member

Reinmar commented Aug 22, 2019

Unfortunately, it does not work still:

image

@Reinmar
Copy link
Member

Reinmar commented Aug 22, 2019

Error:

image

@jodator
Copy link
Contributor Author

jodator commented Aug 22, 2019

Above mentioned bugs fixed with: ckeditor/ckeditor5-table#212. Anyway, we will need a follow-up with better upload checking so the upload (and cleanup) is not triggered more than once for the same image.

@Mgsy
Copy link
Member

Mgsy commented Aug 22, 2019

Now everything works fine 👌

@jodator jodator merged commit 5a729d3 into master Aug 23, 2019
@jodator jodator deleted the t/ckeditor5/1985 branch August 23, 2019 07:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants