Merge pull request #35 from ckeditor/t/34

Fix: The inspector should not scale beyond the height of the visible viewport. Closes #34.
ckeditor · Mar 20, 2019 · 86c287b · 86c287b
2 parents 16fa0e4 + f546305
commit 86c287b
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/src/components/ui.js b/src/components/ui.js
@@ -99,6 +99,7 @@ export default class InspectorUI extends Component {
 			enableResizing={{ top: !this.state.isCollapsed }}
 			disableDragging={true}
 			minHeight={INSPECTOR_MIN_HEIGHT}
+			maxHeight="100%"
 			style={INSPECTOR_STYLES}
 			className={[
 				'ck-inspector',

diff --git a/tests/inspector/components/ui.js b/tests/inspector/components/ui.js
@@ -188,6 +188,12 @@ describe( '<InspectorUI />', () => {
 					expect( rnd.props().minHeight ).to.equal( '100' );
 				} );
 
+				it( 'has #maxHeight', () => {
+					const rnd = wrapper.find( Rnd ).first();
+
+					expect( rnd.props().maxHeight ).to.equal( '100%' );
+				} );
+
 				it( 'has #style', () => {
 					const rnd = wrapper.find( Rnd ).first();