Inspector should be toggled only on alt+f12.

ckeditor · Jul 29, 2020 · 93ecbee · 93ecbee
1 parent af16a9d
commit 93ecbee
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/src/ui.js b/src/ui.js
@@ -180,5 +180,5 @@ function updateBodyHeight( height ) {
 }
 
 function isToggleShortcut( event ) {
-	return event.altKey && event.key === 'F12';
+	return event.altKey && !event.shiftKey && !event.ctrlKey && event.key === 'F12';
 }
diff --git a/tests/inspector/ui.js b/tests/inspector/ui.js
@@ -360,6 +360,18 @@ describe( '<InspectorUI />', () => {
 							type: TOGGLE_IS_COLLAPSED
 						} );
 					} );
+
+					it( 'should not toggle the UI on a global SHIFT+ALT+F12 keyboard shortcut', () => {
+						windowEventMap.keydown( { key: 'F12', altKey: true, shiftKey: true } );
+
+						sinon.assert.notCalled( dispatchSpy );
+					} );
+
+					it( 'should not toggle the UI on a global CTRL+ALT+F12 keyboard shortcut', () => {
+						windowEventMap.keydown( { key: 'F12', altKey: true, ctrlKey: true } );
+
+						sinon.assert.notCalled( dispatchSpy );
+					} );
 				} );
 			} );