Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependencies and adjust the code to the latest changes in CKE 5 #61

Closed
pomek opened this issue Aug 29, 2019 · 1 comment
Closed
Assignees
Milestone

Comments

@pomek
Copy link
Member

pomek commented Aug 29, 2019

I tried to upgrade dependencies defined in the yarn.lock file in #60 but unfortunately, it ends with the duplicated modules error.

I thought that changing numbers in pkg.json will be enough:

{
    "@ckeditor/ckeditor5-basic-styles": "^11.1.4",
    "@ckeditor/ckeditor5-build-decoupled-document": "^12.4.0",
    "@ckeditor/ckeditor5-core": "^12.3.0",
    "@ckeditor/ckeditor5-paragraph": "^11.0.5",
    "@ckeditor/ckeditor5-ui": "^14.0.0",
    "@ckeditor/ckeditor5-utils": "^14.0.0"
}

But it's more complicated and after that, 12 tests fail (related to RTL changes) and 50% of the test log is filled by non-related console logs.

@mlewand mlewand added this to the nice-to-have milestone Sep 16, 2019
@oleq
Copy link
Member

oleq commented Oct 16, 2019

This has been fixed around here #46 (commits).

@oleq oleq closed this as completed Oct 16, 2019
@oleq oleq modified the milestones: nice-to-have, iteration 27 Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants