Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

t/44: Allowed a configuration to CKEditorInspector#attach() to attach the i… #46

Merged
merged 14 commits into from
Sep 20, 2019

Conversation

oleq
Copy link
Member

@oleq oleq commented Apr 8, 2019

Feature: Allowed attaching the inspector collapsed using a configuration passed to CKEditorInspector#attach(). Implemented the CKEditorInspector#destroy() method. Unified CKEditorInspector#attach() arguments syntax and allowed attaching to multiple instances at a time. Closes #44. Closes #42. Closes #48.

BREAKING CHANGE: The CKEditorInspector.attach( 'editor-name', editor ); syntax was deprecated and replaced by an object literal CKEditorInspector.attach( { 'editor-name': editor, ... } );.

…nspector collapsed. Implemented CKEditorInspector#destroy().
@oleq
Copy link
Member Author

oleq commented Apr 16, 2019

We may want to postpone the merge and introduce #48 in this PR.

src/utils.js Outdated Show resolved Hide resolved
src/utils.js Outdated Show resolved Hide resolved
tests/inspector/logger.js Outdated Show resolved Hide resolved
@oleq
Copy link
Member Author

oleq commented Sep 20, 2019

@ma2ciek Can you review it again?

@ma2ciek
Copy link
Contributor

ma2ciek commented Sep 20, 2019

Sure, I'll review it.

@oleq
Copy link
Member Author

oleq commented Sep 20, 2019

I'm bumping deps and aligning to the latest API.

@oleq
Copy link
Member Author

oleq commented Sep 20, 2019

Looks like it's ready.

@ma2ciek ma2ciek self-requested a review September 20, 2019 12:46
src/logger.js Show resolved Hide resolved
@ma2ciek ma2ciek merged commit 69ad014 into master Sep 20, 2019
@ma2ciek ma2ciek deleted the t/44 branch September 20, 2019 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants