Added bottom margin to body element when inspector is collapsed. #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pomek
requested changes
Oct 11, 2021
There was a problem hiding this comment.
LGTM, but there is one thing that could be improved.
The div.ck-inspector.ck-inspector_collapsed element contains the height:* style definition. The value is defined as const (30px).
The same value is also specified in the body[style] attribute:
<body <!-- ... --> style="--ck-inspector-collapsed-height:30px;>
Hence, the div element could read its height from the variable.
pomek
reviewed
Oct 11, 2021
pomek
reviewed
Oct 11, 2021
Co-authored-by: Kamil Piechaczek <pomek@users.noreply.github.com>
|
The height is already set using this variable. I fiddled around with it a bit, and i think we should leave it as it is, changing this seems to create more mess than necessary. Line 77 in 75adce3 |
pomek
approved these changes
Oct 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other: Added bottom margin to the
<body>element when the inspector is collapsed to avoid covering the footer. Closes #126.