Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i/64: The inspector should render the RTL content in the trees properly. #66

Merged
merged 1 commit into from
Oct 24, 2019

Conversation

oleq
Copy link
Member

@oleq oleq commented Oct 24, 2019

Fix: The inspector should render the RTL content in the trees properly. Closes #64.

@oleq oleq requested a review from jodator October 24, 2019 08:56
@jodator
Copy link
Contributor

jodator commented Oct 24, 2019

I'm not sure if the change is visible enough (at least to me):

  1. Moving caret left (advance to the end of a text node):

Peek 2019-10-24 11-55

  1. Moving caret right (advance to the beginning of a text node):

Peek 2019-10-24 11-55a

  1. Jumping from right to left using home and end

Peek 2019-10-24 11-56

This is the most outstanding "issue" for me - the CKEInspector "Model" panel is LTR while moving a caret to the boundary of an RTL text node occurs as a jump of a selection - while technically it is correctly rendered at the beginning of a container and before text node.

Now, I've tried to change the whole Model view to RTL:

Peek 2019-10-24 12-08

... and I don't know - looks awkward (as any RTL text) but the "jump" feels a bit more natural now.

ps.: The closing element, like </paragraph> is rendered as <paragraph/> (the / is rendered as in RTL) currently - feels OKish in RTL model view.

@jodator
Copy link
Contributor

jodator commented Oct 24, 2019

So, after @oleq guided me to the "compact text" option, the PR looks pretty well and it is not so confusing. The jumping comes from the way how RTL is displayed in LTR nodes so we can't do much about it.

Copy link
Contributor

@jodator jodator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides my inability to click "compact text" everything works nice. 👍

@jodator jodator merged commit 40c3102 into master Oct 24, 2019
@jodator jodator deleted the i/64 branch October 24, 2019 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The caret movement might be misleading with RTL
2 participants