Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

t/ckeditor5/1151: Passed editor content direction to the bindTwoStepCaretToAttribute() helper in the LinkEditing plugin #244

Merged
merged 5 commits into from Aug 12, 2019
Merged

t/ckeditor5/1151: Passed editor content direction to the bindTwoStepCaretToAttribute() helper in the LinkEditing plugin #244

merged 5 commits into from Aug 12, 2019

Conversation

oleq
Copy link
Member

@oleq oleq commented Jul 30, 2019

Suggested merge commit message (convention)

Other: Passed editor content direction to the bindTwoStepCaretToAttribute() helper in the LinkEditing plugin. See ckeditor/ckeditor5#1151.

Additional information

A piece of ckeditor/ckeditor5#1881.

@oleq oleq mentioned this pull request Jul 30, 2019
Merged
14 tasks
@coveralls
Copy link

coveralls commented Jul 30, 2019 •
edited

Coverage Status

Coverage decreased (-50.5%) to 49.466% when pulling dbe6631 on t/ckeditor5/1151 into 14e5803 on master.

@oleq oleq added the pr:sub label Jul 30, 2019
@oleq oleq marked this pull request as ready for review August 5, 2019 14:18
Reinmar
Reinmar suggested changes Aug 7, 2019
View reviewed changes
Copy link
Member

@Reinmar Reinmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As commented in the engine – the list of params grew too much.

@Reinmar Reinmar self-assigned this Aug 7, 2019
@Reinmar Reinmar merged commit 73bf132 into master Aug 12, 2019
@Reinmar Reinmar deleted the t/ckeditor5/1151 branch August 12, 2019 10:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Reinmar Reinmar Reinmar approved these changes

Assignees

@Reinmar Reinmar

Labels
pr:sub
Projects
None yet
Milestone
No milestone
3 participants
@oleq @coveralls @Reinmar