Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Post fixer tries to use non-transformed changes.sourcePosition #2993

Closed
scofalik opened this issue Aug 23, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-list#79
Closed

Post fixer tries to use non-transformed changes.sourcePosition #2993

scofalik opened this issue Aug 23, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-list#79
Assignees
@scofalik
Labels
package:list type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 11

Comments

@scofalik
Copy link
Contributor

modelChangePostFixer takes data from model.Document#event:change - data.range and data.sourcePosition. The sourcePosition is a value before the change happened. This means that if the change has moved some nodes before sourcePosition, the sourcePosition needs to be updated before it is used in the rest of algorithm.
@scofalik scofalik self-assigned this Aug 23, 2017
pjasiun referenced this issue in ckeditor/ckeditor5-list Aug 25, 2017
Merge pull request #79 from ckeditor/t/78
3d8814e 
Fix: Fixed a bug when editor sometimes crashed when list item was moved outside and before a container in which it was. Closes #78.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-list Oct 9, 2019
@mlewand mlewand added this to the iteration 11 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:list labels Oct 9, 2019
@scofalik scofalik mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scofalik scofalik

Labels
package:list type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 11
2 participants
@scofalik @mlewand