Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of ViewListElement #2999

Closed
szymonkups opened this issue Jan 24, 2018 · 1 comment · Fixed by ckeditor/ckeditor5-list#90
Closed

Get rid of ViewListElement #2999

szymonkups opened this issue Jan 24, 2018 · 1 comment · Fixed by ckeditor/ckeditor5-list#90
Assignees
@szymonkups
Labels
package:list type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone
iteration 14

Comments

@szymonkups
Copy link
Contributor

During view refactoring we want to prevent ability to extend element classes. This will allow us to have limited set of base classes to handle.
ViewListItemElement is a class that only adds different getFillerOffset function. This can be done by creating instance of ContainerElement class and change its getFillerOffset function to the custom one. This will work properly when element is cloned because it is cloned manually: https://github.com/ckeditor/ckeditor5-engine/blob/master/src/view/element.js#L187.
@szymonkups szymonkups self-assigned this Jan 24, 2018
@Reinmar
Copy link
Member

Reinmar commented Jan 24, 2018

Will fix https://github.com/ckeditor/ckeditor5-list/issues/27.

pjasiun referenced this issue in ckeditor/ckeditor5-list Jan 24, 2018
Merge pull request #90 from ckeditor/t/89
e4ac704 
Other: Removed ViewListItemElement class and introduced createViewListItemElement utility method. Closes #89.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-list Oct 9, 2019
@mlewand mlewand added this to the iteration 14 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:task This issue reports a chore (non-production change) and other types of "todos". package:list labels Oct 9, 2019
@szymonkups szymonkups mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@szymonkups szymonkups

Labels
package:list type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
iteration 14
Development

Successfully merging a pull request may close this issue.

Removed ViewListItemElement. ckeditor/ckeditor5-list
3 participants
@Reinmar @szymonkups @mlewand