Fixed: List postfixers should check if attribute is allowed od elemen… #104
Conversation
src/converters.js
Outdated
| @@ -602,13 +602,15 @@ export function modelChangePostFixer( model, writer ) { | |||
| // In case of renamed element. | |||
| const item = entry.position.nodeAfter; | |||
|
|
|||
| if ( item.hasAttribute( 'indent' ) ) { | |||
| // Only remove 'indent' attribute from items that doesn't allow such attribute. #103 | |||
There was a problem hiding this comment.
Could you add a comment that this code should be removed once https://github.com/ckeditor/ckeditor5-engine/issues/1228 is resolved?
There was a problem hiding this comment.
The whole check, am I right?
|
As discussed in https://github.com/ckeditor/ckeditor5-list/issues/103#issuecomment-389079136 we should rather change the name of list item's attributes. Those attrs which are only used with list items should be prefixed. |
|
@Reinmar OK I've changed the PR to renaming |
|
What about other repos? |
Do you mean like docs in ps.: OK I've found some tests in other repos to update also |
Yup, I meant the tests. |
|
@Reinmar so it's done - see updated PR comment with proper branches. |
Suggested merge commit message (convention)
Other: Rename list attributes
indentandtypetolistIndentandlistType. Closes ckeditor/ckeditor5#3003.BREAKING CHANGE: The
indentattribute is now calledlistIndent. See ckeditor/ckeditor5#3003 for more information.BREAKING CHANGE: The
typeattribute is now calledlistType. See ckeditor/ckeditor5#3003 for more information.Additional information
<video type="">issue. But it should be fixed by schema itself.