Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Tests: Fix list tests so they logic isn't changed after incorporating… #108

Merged
merged 1 commit into from Jul 10, 2018

Conversation

jodator
Copy link
Contributor

@jodator jodator commented Jul 10, 2018

Suggested merge commit message (convention)

Tests: Fix list tests so they logic isn't changed after incorporating selection post-fixer. Closes ckeditor/ckeditor5#3004.


Additional information

  • As @scofalik suggested I've reverted some changes in the test so their logic remains the same as originally written. Now the editor setup is done as a separate step then actionCallback that runs the actual test steps. The selection in tests is not set - the [] is parsed and passed to the actionCallback that runs the test.

@jodator jodator requested a review from scofalik July 10, 2018 11:55
@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 100.0% when pulling 28af705 on t/107 into 7447b0d on master.

@scofalik scofalik merged commit dec1c79 into master Jul 10, 2018
@scofalik scofalik deleted the t/107 branch July 10, 2018 15:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants