Introduced todo lists.

[oskarwrobel]

Suggested merge commit message (convention)

Feature: Introduced todo lists. Closes ckeditor/ckeditor5#1434.

---

TODO before merge:

• improve v -> m conversion for data pipeline
• use command for toggling check state after clicking on checkbox
• add and improve API docs
• increase CC to 100% https://github.com/ckeditor/ckeditor5-list/issues/126
• do not use Renderer for getting changed checkmark elements
• improve manual test

[coveralls]

Coverage remained the same at ?% when pulling 7020e67 on t/1434 into a792961 on master.

[pjasiun]

1. Select: list + todo list + list
2. press ctrl + space

Result:

position.js:362 Uncaught TypeError: Cannot read property 'is' of undefined
    at Function._createAfter (position.js:362)
    at DowncastWriter.createPositionAfter (downcastwriter.js:956)
    at DowncastDispatcher.<anonymous> (todolistconverters.js:186)
    at DowncastDispatcher.fire (emittermixin.js:207)
    at DowncastDispatcher._testAndFire (downcastdispatcher.js:466)
    at DowncastDispatcher.convertAttribute (downcastdispatcher.js:240)
    at DowncastDispatcher.convertChanges (downcastdispatcher.js:141)
    at editingcontroller.js:90
    at View.change (view.js:467)
    at Document.EditingController.listenTo.priority (editingcontroller.js:89)

[oskarwrobel]

1. Select: list + todo list + list
2. press ctrl + space

Result:

position.js:362 Uncaught TypeError: Cannot read property 'is' of undefined
    at Function._createAfter (position.js:362)
    at DowncastWriter.createPositionAfter (downcastwriter.js:956)
    at DowncastDispatcher.<anonymous> (todolistconverters.js:186)
    at DowncastDispatcher.fire (emittermixin.js:207)
    at DowncastDispatcher._testAndFire (downcastdispatcher.js:466)
    at DowncastDispatcher.convertAttribute (downcastdispatcher.js:240)
    at DowncastDispatcher.convertChanges (downcastdispatcher.js:141)
    at editingcontroller.js:90
    at View.change (view.js:467)
    at Document.EditingController.listenTo.priority (editingcontroller.js:89)

That's strange. Unit tests cover this case with no exception. No, it's not :)

Fixed.

[oskarwrobel]

You can't select two items in a table cell.

Edit: Actually, it's a different case. The selection collapses after reaching a checkbox. On longer words it works fine.

Fixed.

[oskarwrobel]

Steps to reproduce

1. Create two todo list items.
2. Check the second one.
3. Select both items.
4. Convert it to an ordered list.

Current result

The editor crashes.

Fixed.

[Mgsy]

It looks good to me 👍

[Mgsy]

During testing a collaboration I've noticed that shortcut for checking list on OS X triggers changing the language. We should consider if Ctrl + Space is a good idea. cc @pjasiun @oskarwrobel

Edit: It turned out that I had enabled some system shortcuts which aren't enabled by default. After talking with @pjasiun, we decided to leave it as it is.

[oliverguenther]

This fails when upcasting checkboxes with binary attributes input type="checkbox" checked which are parsed as checked = "". So this would need to check against an empty string as well.

[pomek]

Wouldn't data.viewItem.checked be enough?

[pjasiun]

It will be solved in the follow-up ticket https://github.com/ckeditor/ckeditor5-list/issues/138.

[oliverguenther]

@pomek Yes that should work

Great thanks! Also, awesome work on the tasklist 🍻

[kidrahahjo]

@oskarwrobel Hey, I have a question regarding creating an interactive checklist for a GitHub's pull request template. Do you have any idea how this can be done?