This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Add tests case to increase CC when splitting inside list. #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The else statement in viewToModelListItemChildrenConverter() for checking conditions after split wasn't covered after fixing autoparagraphing. This tests does the "improper" way of setting modelCursor when splitting to allowed parent.
Reinmar
reviewed
Aug 26, 2019
scofalik
reviewed
Aug 26, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Tests: Add tests case to increase CC when splitting inside list. Closes ckeditor/ckeditor5#3012.
Additional information
checking conditions after split weren't covered after autoparagraphing.