This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Use dispatchers configured in editor.conversion #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rovided by DataController and EditingController
|
@Reinmar I've checked the PR and it generally does the same as a previous code. The thing is that we should stick to one (preferred) way of defining conversion utilities and keep them in sync. I'm going to merge it since IMO we should stick to one way of doing things. I'll create an issue for that so we could sort it out in other repos or revert changes of this PR. |
jodator
added a commit
that referenced
this pull request
Nov 26, 2019
Internal: Refactor use of conversion dispatchers. Closes ckeditor/ckeditor5#5792.
jodator
approved these changes
Nov 26, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm creating a custom editor build that uses a different set of up- and downcast dispatchers, which are currently not used by the list plugin.
In order to select the correct dispatchers, I'd suggest to to fetch them using from the
editor.conversion.for(dispatcherName)instead of using the ones within the Editing- and DataControllers.This change should not make a difference to other builds since the default
dataUpcast,dataDowncastandupcastdispatchers withineditor.conversionare exactly what has been used before, anyways.