Merge f3c2e41 into 3fcc3f9

ckeditor · May 23, 2019 · f012769 · f012769
2 parents 3fcc3f9 + f3c2e41
commit f012769
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/src/mediaregistry.js b/src/mediaregistry.js
@@ -298,7 +298,8 @@ class Media {
 					tag: 'a',
 					attributes: {
 						class: 'ck-media__placeholder__url',
-						target: 'new',
+						target: '_blank',
+						rel: 'noopener noreferrer',
 						href: this.url
 					},
 					children: [

diff --git a/tests/mediaembedediting.js b/tests/mediaembedediting.js
@@ -927,7 +927,7 @@ describe( 'MediaEmbedEditing', () => {
 						'<div[^>]+>' +
 							'<div class="ck ck-media__placeholder ck-reset_all">' +
 								'<div class="ck-media__placeholder__icon">.*</div>' +
-								`<a class="ck-media__placeholder__url" href="${ expectedUrl }" target="new">` +
+								`<a class="ck-media__placeholder__url" href="${ expectedUrl }" rel="noopener noreferrer" target="_blank">` +
 									`<span class="ck-media__placeholder__url__text">${ expectedUrl }</span>` +
 									'<span class="ck ck-tooltip ck-tooltip_s">' +
 										'<span class="ck ck-tooltip__text">Open media in new tab</span>' +

diff --git a/theme/mediaembed.css b/theme/mediaembed.css
@@ -19,3 +19,7 @@
 	from being "squashed" in tight spaces, e.g. in table cells (#44) */
 	min-width: 15em;
 }
+
+.ck-editor__editable:not( .ck-read-only ) .ck-widget:not( .ck-widget_selected ) .ck-media__placeholder {
+	pointer-events: none;
+}