Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use CKEditor 5 typings #110

Closed
pomek opened this issue Jul 8, 2022 · 0 comments · Fixed by #137
Closed

Use CKEditor 5 typings #110

pomek opened this issue Jul 8, 2022 · 0 comments · Fixed by #137
Assignees
@przemyslaw-zan
Labels
squad:devops Issue to be handled by the Devops team. type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Milestone
iteration 61

Comments

@pomek
Copy link
Member

pomek commented Jul 8, 2022

📝 Provide a description of the new feature

Story

  • Given: I am a user who wants to create a new package.
  • And: I want to use TypeScript.
  • When: I execute the create-package ... command.
  • And: I select TypeScript when it asks about the output type.
  • Then: The generated package should not import non-official typings.

Hints

  • ⚠️ This can be done once CKEditor 5 is fully migrated to TypeScript.
  • Make sure to check the following commands: tests, manual sample, and DLL building.
@pomek pomek added squad:devops Issue to be handled by the Devops team. type:feature This issue reports a feature request (an idea for a new functionality or a missing option). labels Jul 8, 2022
@CKEditorBot CKEditorBot added the status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. label Feb 26, 2023
@przemyslaw-zan przemyslaw-zan self-assigned this Feb 28, 2023
@CKEditorBot CKEditorBot added status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. and removed status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. labels Feb 28, 2023
@przemyslaw-zan przemyslaw-zan mentioned this issue Feb 28, 2023
Merged
@pomek pomek closed this as completed in #137 Mar 9, 2023
pomek added a commit that referenced this issue Mar 9, 2023
@pomek
Merge pull request #137 from ckeditor/i/110
f2f8264 
Feature: Replaced the community typings with the official CKEditor 5. Closes #110.

Other: The `ckeditor5` package is no longer a dependency of a created package. Instead, it is marked as a peer dependency to enable using the newly created package with the latest CKEditor 5 versions.
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Mar 9, 2023
@CKEditorBot CKEditorBot added this to the iteration 61 milestone Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@przemyslaw-zan przemyslaw-zan

Labels
squad:devops Issue to be handled by the Devops team. type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Projects
None yet
Milestone
iteration 61
Development

Successfully merging a pull request may close this issue.

Implemented use of official CKEditor5 typings ckeditor/ckeditor5-package-generator
3 participants
@pomek @CKEditorBot @przemyslaw-zan